Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quit Pygame when cliffwalking environment is closed #1297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sjmikler
Copy link

Description

Environment CliffWalking-v0 with human rendering enabled is not calling pygame.quit() when closing. This causes the rendered pygame window to stick until pygame.quit() is called manually.

This PR implements the missing method close() similarly as in other toy_text environments.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

I believe the missing items from the Checklist are not necessary for this bugfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant